Re: patch for sysfs in the cyclades driver

From: Roland Dreier
Date: Thu Nov 04 2004 - 14:20:03 EST


Roland> I assume this is OK (since there is already one in-kernel
Roland> driver doing it), but Greg, can you confirm that it's
Roland> definitely OK for a driver to use class_set_devdata() on a
Roland> class_device from class_simple_device_add()?

Greg> Hm, I think that should be ok, but I'd make sure to test it
Greg> before verifying that it really is :)

Well class_simple.c definitely doesn't use class_data/class_set_devdata()
now (and as I said drivers/scsi/st.c is using this on a class_simple
device). The question is whether you can bless this situation as part
of the API, or whether some time in the future class_simple might
start using class_data.

- R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/