Re: [PATCH 504] m68k: smp_lock.h: Avoid recursive include

[Linus Torvalds]

This one is _totally_ broken. 

Not only is that include not recursive, but it immediately breaks any SMP 
compile because that header file _needs_ the definition of "task_struct".

I applied it without realizing it, but I'll undo it and I hope you fix 
your broken tree so that I don't ever have to see this broken patch 
again..

		Linus

On Sun, 31 Oct 2004, Geert Uytterhoeven wrote:
>
> smp_lock.h: Avoid recursive include
> 
> Signed-off-by: Roman Zippel <zippel@xxxxxxxxxxxxxx>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Signed-off-by: Linus Torvalds <torvalds@xxxxxxxx>
> 
> --- linux-2.6.10-rc1/include/linux/smp_lock.h	2004-04-28 15:47:31.000000000 +0200
> +++ linux-m68k-2.6.10-rc1/include/linux/smp_lock.h	2004-10-20 22:24:05.000000000 +0200
> @@ -2,7 +2,6 @@
>  #define __LINUX_SMPLOCK_H
>  
>  #include <linux/config.h>
> -#include <linux/sched.h>
>  #include <linux/spinlock.h>
>  
>  #if defined(CONFIG_SMP) || defined(CONFIG_PREEMPT)
> 
> Gr{oetje,eeting}s,
> 
> 						Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> 							    -- Linus Torvalds
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/