Re: [PATCH 4/8] sonypi: rework input support

[Pavel Machek]

Hi!

> > > +	{ SONYPI_EVENT_FNKEY_F1, 		KEY_FN_F1 },
> > > +	{ SONYPI_EVENT_FNKEY_F2, 		KEY_FN_F2 },
> > > +	{ SONYPI_EVENT_FNKEY_F3, 		KEY_FN_F3 },
> [...]
> 
> > KEY_FN_D does not sound too usefull (similar for FN_F1..FN_F12). Are
> > there some pictures on those keys? 
> 
> Some of them have pictures (Fn-Esc for suspend to ram, Fn-F12 for
> suspend to disk, Fn-F3 for mute, Fn-F4 for launching the volume
> controls, Fn-F5 for launching the brightness controls, Fn-F7/F8 for
> changing from LCD to external monitor or TV). All the others have
> no pictures on them.

In such case I'd assign meaningfull events at least to keys with
labels?

> > Mapping FN_F3 to for example
> > KEY_SUSPEND would be usefull...
> 
> This sound like policy to me and should not be done into the
> kernel but somewhere you can configure it, like in a keyboard 
> keymap or something like that.

Eh? You are basically doing arbitrary mapping between sony events to
linux keycodes. You might as well make the mapping usefull while you
are at it.
								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/