Re: [PATCH] WOL for sis900

[Jeff Garzik]

Malte Schröder wrote:
> Hello,
> I have applied the patch from http://lkml.org/lkml/2003/7/16/88 manually 
> to 2.6.7 (also works on 2.6.{8,9}) and have been using it since then.
> Attached is a diff against 2.6.9.

Two comments:

1) Please include a signed-off-by line, as per

	http://linux.yyz.us/patch-format.html
		and
	http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt

2) Please use ethtool to enable/disable WOL.  No need for a module option.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/