Re: RFC: [2.6 patch] Eicon: disable debuglib for modules

[Armin Schindler]

On Sat, 30 Oct 2004, Adrian Bunk wrote:
> Is there a good reason why debuglib is enabled for modules?

Yes.
Without it, there would be no possibility to use the maintainance module
to debug the isdn/card/capi interaction.

> If not, I'd propose the patch below to disable it.

I have to disagree. This patch would disable a major feature of the
diva driver collection.

Armin

> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
>
> --- linux-2.6.10-rc1-mm2-full/drivers/isdn/hardware/eicon/platform.h.old	2004-10-30 08:39:51.000000000 +0200
> +++ linux-2.6.10-rc1-mm2-full/drivers/isdn/hardware/eicon/platform.h	2004-10-30 08:40:28.000000000 +0200
> @@ -35,10 +35,8 @@
>
>  #include "cardtype.h"
>
> -/* activate debuglib for modules only */
> -#ifndef MODULE
> +/* disable debuglib */
>  #define DIVA_NO_DEBUGLIB
> -#endif
>
>  #define DIVA_INIT_FUNCTION  __init
>  #define DIVA_EXIT_FUNCTION  __exit
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/