Re: [PATCH 2/4] Driver core: add driver_probe_device

[Greg KH]

On Fri, Oct 29, 2004 at 11:57:52AM -0700, Dmitry Torokhov wrote:
> > I really like the "driver" part in the device.  But not as a file, let's
> > make it a symlink back to the driver that is bound to the device at that
> > point in time.  This makes it just like the other symlinks in the sysfs
> > tree.
> > 
> > But if we do that, we still don't have a way to implement what you are
> > really trying to do (and it breaks your code as you already have a
> > driver file.)  I'll work on what I propose instead in my next message
> > (will be a few hours, have real work to do for a bit, sorry...)
> >
> 
> Well, we can have driver as a symlink and rename my "driver" attribute
> into something like "drvctl" (just an example, maybe somebody has better
> name in mind, I am not fixed on the name) and make it writable only.

Yes, that's exactly what I was thinking of.  But as you wanted it to do
three different things... Hm, no, I guess you only wanted it to do 2
things.  Ah, that's not bad at all.  Been traveling too long, can't
remember threads...

> I think it should work well as now device and driver objects are very
> symmetrical - they both similarly linked together via device->driver
> and driver->device).

I agree.  Hm, I guess the remaining 2 patches aren't that far away from
what I was thinking about originally. 

Ok, care to redo the "driver" patch to be a symlink instead?  I think
the last patch doesn't really need any changes, does it?

Hm, but how does this play with the current pci "add a new device id"
scheme?  Can this "bind_mode" scheme work with that?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/