Re: [2.6 patch] net/typhoon.c: remove an unused function

From: David Dillow
Date: Thu Oct 28 2004 - 19:17:51 EST


On Fri, 2004-10-29 at 01:06 +0200, Adrian Bunk wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> The patch below removes an unused function from drivers/net/typhoon.c

NAK -- I'd prefer to make it be used, which was the reason it was there
in the first place... not sure why it wasn't...

===== drivers/net/typhoon.c 1.25 vs edited =====
--- 1.25/drivers/net/typhoon.c 2004-10-21 18:42:58 -04:00
+++ edited/drivers/net/typhoon.c 2004-10-28 20:06:45 -04:00
@@ -1687,8 +1687,7 @@
skb = rxb->skb;
dma_addr = rxb->dma_addr;

- rxaddr += sizeof(struct rx_desc);
- rxaddr %= RX_ENTRIES * sizeof(struct rx_desc);
+ typhoon_inc_rx_index(&rxaddr, 1);

if(rx->flags & TYPHOON_RX_ERROR) {
typhoon_recycle_rx_skb(tp, idx);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/