Begin forwarded message:
Date: Thu, 28 Oct 2004 17:34:19 +0800 (CST)
From: "Zhu, Yi" <yi.zhu@xxxxxxxxx>
To: Andrew Morton <akpm@xxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
Subject: [PATCH] Fix e100 suspend/resume w/ 2.6.10-rc1 and above (due to pci_save_state change)
Hi,
Recent 2.6.10-rc1 merged the pci_save_state change. This prevents some
drivers from working with suspend/resume. The reason is the
pci_save_state() called in driver's ->suspend doesn't take effect any more,
since pci bus ->suspend will override it. And the two states might be
different in some drivers, i.e. e100. I don't know if there are other
drivers also suffer from it.
Thanks,
-yi
Signed-off-by: Zhu Yi <yi.zhu@xxxxxxxxx>
--- /tmp/e100.c 2004-10-28 16:31:41.000000000 +0800
+++ drivers/net/e100.c 2004-10-28 16:33:14.000000000 +0800
@@ -2309,9 +2309,7 @@ static int e100_suspend(struct pci_dev *
- pci_save_state(pdev);
pci_enable_wake(pdev, state, nic->flags & (wol_magic | e100_asf(nic)));
- pci_disable_device(pdev);
pci_set_power_state(pdev, state);