Re: Input: sunkbd concern

From: Dmitry Torokhov
Date: Tue Oct 26 2004 - 20:34:00 EST


On Tuesday 26 October 2004 08:06 pm, David S. Miller wrote:
> On Fri, 22 Oct 2004 18:33:04 -0500
> Dmitry Torokhov <dtor_core@xxxxxxxxxxxxx> wrote:
>
> > I have been looking at sunkbd.c and it seems that it attaches not only to
> > ports that speak SUNKBD protocol but also to ports that do not specify any
> > protocol:
> >
> > if ((serio->type & SERIO_PROTO) && (serio->type & SERIO_PROTO) != SERIO_SUNKBD)
> > return;
> >
> > Was that an oversight or it was done intentionally?
>
> I believe it is intentional.
>
> If SERIO_PROTO bits are all clear, this is supposed to have
> a special meaning in that any keyboard driver can claim
> the serio line.
>
> So if it's the "wildcard" zero value, or specifically SERIO_SUNKBD,
> we'll attach to it.
>

I would buy if I see another keyboard doing this, but so far only sunkbd
does this. The rest of keyboards connecting to a RS232-type ports require
exact protocol match...

The background is that I am trying to create a bus "match" function for
serio and trying to understand the requirements...

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/