Re: lowmem_reserve (replaces protection)

From: Rik van Riel
Date: Mon Oct 25 2004 - 21:08:27 EST


On Mon, 25 Oct 2004, Andrea Arcangeli wrote:

> This is a forward port to 2.6 CVS of the lowmem_reserve VM feature in
> the 2.4 kernel.
>
> http://www.kernel.org/pub/linux/kernel/people/andrea/patches/v2.6/2.6.9/lowmem_reserve-1

- unsigned long protection[MAX_NR_ZONES];
+ unsigned long lowmem_reserve[MAX_NR_ZONES];

The gratituous renaming of variable and function names makes
it hard to see what this patch actually changed. Hard enough
that I'm not sure what the behavioural difference is supposed
to be.

--
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/