Re: [PATCH 20/28] HOTPLUG: call_usermodehelper callback support

[Christoph Hellwig]

On Mon, Oct 25, 2004 at 10:48:40AM -0400, Mike Waychison wrote:
> This patch extends the call_usermodehelper api by adding a callback variant.
> The callback is made right when the system is about to call execve into the
> new process.  This allows for the caller to provide changes to the default
> environment right before the exec takes place.  Note: the context of the
> callback will be _from within another process_.

I don't like this at all.  First it's the usual fork() + exec() vs spawn() with
gazillions of arguments debatte, second this sounds far too complex to do it in
kernelspace to me.  Why can't you do the enviroment changes from the program
beeing executed?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/