Re: [PATCH] reduce top(1) CPU usage by an order of magnitude

[Denis Vlasenko]

On Monday 25 October 2004 10:35, Andi Kleen wrote:
> Denis Vlasenko <vda@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> writes:
> 
> > Patch is not mine, Paulo Marques <pmarques@xxxxxxxxxxxx>
> > wrote it.
> 
> The bug is in your top. It shouldn't read /proc/*/wchan
> by default unless the user switches on WCHAN display.
> Just disable that and it will be even faster. My top
> doesn't read it at all, you probably got some buggy
> version.

This is top from procps-2.0.18.
You are right, top may skip reading wchan, I will look into it.
However, if I do request WCHAN, I still want top to be fast.
 
> Also btw we normally let people submit their patches themselves.

I just wanted to prevent this patch from being missed.
--
vda

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/