Re: DVD/ide-cd related Oops 2.6.[89]-mm

[tabris]

On Friday 22 October 2004 10:35 am, Bartlomiej Zolnierkiewicz wrote:
> On Fri, 22 Oct 2004 05:01:45 -0400, Tabris <tabris@xxxxxxxxxx> wrote:
> >         undecoded slave fixup is a oneliner patch in ide-probe to
> > recognize both of my Maxtor drives that appear to have the same
> > serial number, D3000000. This fix was discussed a month ago or so,
> > as I had run into it, but nothing official came of it, and it was
> > never merged to -mm.
>
> Did you test it on different controller (as asked by Eric)?
>
> > Patch attached.
>
> thanks, I'll apply it
	Patch attached with a comment. Possibly not necessary, but as it's a 
fixup, probably should anyway.
>
> Bartlomiej

--
tabris
-
Some people only open up to tell you that they're closed.
Signed-off by tabris@xxxxxxxxxx

--- ide-probe.c~	2004-10-22 12:40:41.366608575 -0400
+++ ide-probe.c	2004-10-22 12:41:40.789111900 -0400
@@ -730,6 +730,8 @@ static void probe_hwif(ide_hwif_t *hwif)
 			    /* And beware of confused Maxtor drives that go "M0000000000"
 			      "The SN# is garbage in the ID block..." [Eric] */
 			    strncmp(drive->id->serial_no, "M0000000000000000000", 20) &&
+			    /* Same goes for another set of Maxtor drives that say "D3000000" */
+			    strncmp(drive->id->serial_no, "D3000000", 8) &&
 			    strncmp(hwif->drives[0].id->serial_no, drive->id->serial_no, 20) == 0) {
 				printk(KERN_WARNING "ide-probe: ignoring undecoded slave\n");
 				drive->present = 0;