Re: [patch 2.6.9 0/11] Add MODULE_VERSION to several networkdrivers

From: Arjan van de Ven
Date: Thu Oct 21 2004 - 09:21:08 EST


On Thu, 2004-10-21 at 14:55, John W. Linville wrote:
> > Not really. I have absolutely no problem with a MODULE_VERSION macro
> > *IF* the version it advertises means something. However if the version
> > it advertises has no meaning whatsoever (eg the version number never
> > gets updated) then imo it's better to NOT advertise anything so that
> > other tools (like dkms) don't make assumptions and decisions based on
> > nothing-meaning data.
>
> Again, I think it would have to be the maintainer's responsibility
> to make the version numbers meaningful.

absolutely; however you're not the maintainer of all of the ones you
patched... and I still argue that until the number is meaningful
exporting it as meaning something is more harm than good.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/