Re: [parisc-linux] [PATCH] Add key management syscalls to non-i386 archs

From: Matthew Wilcox
Date: Thu Oct 21 2004 - 08:10:20 EST


On Wed, Oct 20, 2004 at 03:44:15PM +0100, David Howells wrote:
> The attached patch adds syscalls for almost all archs (everything barring
> m68knommu which is in a real mess, and i386 which already has it).
>
> It also adds 32->64 compatibility where appropriate.

> --- linux-2.6.9-bk4/arch/parisc/kernel/syscall_table.S 2004-06-18 13:43:47.000000000 +0100
> +++ linux-2.6.9-bk4-keys/arch/parisc/kernel/syscall_table.S 2004-10-20 14:58:51.533643420 +0100
> @@ -341,5 +341,7 @@
> ENTRY_SAME(mq_timedreceive)
> ENTRY_SAME(mq_notify)
> ENTRY_SAME(mq_getsetattr)
> - /* Nothing yet */ /* 235 */
> + ENTRY_SAME(add_key) /* 235 */
> + ENTRY_SAME(request_key)
> + ENTRY_SAME(keyctl)

Um, no. Should be ENTRY_COMP() if there's compat syscalls. And those
particular syscall numbers have already been assigned (blame Linus for
dropping the PA-RISC patch on the floor instead of including it in 2.6.9).

--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/