Re: [PATCH] lockd: replace semaphore, sleep_on

[Trond Myklebust]

> On Wed, Oct 20, 2004 at 09:15:43PM +0200, Thomas Gleixner wrote:
> > 
> > Use wait_event, completion instead of the obsolete sleep_on functions
> > and the abused semaphore

What is the point of all this timeout business when starting/stopping
lockd? We sure as hell don't want lockd to survive us if we are the
process that is responsible for killing it, and neither do we want to
start locking if there is no lockd to handle callbacks.
Please see the example of rpciod in net/sunrpc/sched.c for how to do
this correctly.

As for the client changes to the GRANTED mechanism, where is
wait_for_completion_timeout() defined? It is not part of Linus' kernel.

Cheers,
  Trond

-- 
Trond Myklebust <trond.myklebust@xxxxxxxxxx>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/