Re: [PATCH] Remove union u from linux/fs.h

[Amit Gud]

Give me one simple use of that union except for the sake of backward
compatibilty. BTW, all stable kernels, I guess, definitely make
something or the other incompatible.

Though removing it is no smartness, there is no point in keeping dead
remains of the past, especially if it makes us look dumb.

AG


On Wed, 20 Oct 2004 14:10:15 +0100, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Wed, Oct 20, 2004 at 02:43:59PM +0530, Amit Gud wrote:
> > Do we need the foolish-looking union with just single entry (void
> > *generic_ip) in the struct inode linux/fs.h anymore? Why not remove
> > it?
> >
> > This patch does that along with the changes in other parts of the
> > kernel that references the union. Its compile-tested and applies
> > cleanly to 2.6.9 vanilla.
> 
> I don't think we shoould do such purely cosmetic changes that break backwards
> compatibility during stable series.
> 
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/