Re: iproute2 and 2.6.9 kernel headers (was Re: [ANNOUNCE] iproute22.6.9-041019)

[David Woodhouse]

On Wed, 2004-10-20 at 11:41 +0200, Harald Welte wrote:
> On Wed, Oct 20, 2004 at 09:00:17AM +0200, Harald Welte wrote:
> > I'll take care of this. sorry fort he inconvenience.
> 
> I should actually read mails befor replying ;)  I thought the bug was in
> lnstat - but apparently it wasn't.
> 
> The include bug seems non-trivial to fix. (how do I hate kernel include
> from userspace issues):
> 
> apparently __KERNEL_STRICT_NAMES is definde somewhere (glibc?) which
> prevents __le16, __le64 and others from being defined in linux/types.h.
> 
> Just reietting it like this doesn't help much:

No, it wouldn't.

The time has come to fix it properly instead. Anything which these tools
actually need from the kernel headers should be moved into a separate
header file (still in the kernel source) which is usable from _both_
kernel and userspace. It should use standard types (like uint16_t etc)
instead of kernel-private types, and shouldn't have any #if{n,}def
__KERNEL__ in it. Ideally, it would be in a different directory too --
but we can worry about that later.

-- 
dwmw2


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/