Re: [PATCH] patsubstfor LOCALVERSION and -fno-omit-frame-pointer

From: Sam Ravnborg
Date: Sat Oct 16 2004 - 17:03:06 EST


On Sun, Sep 12, 2004 at 06:36:35PM +0900, Tejun Heo wrote:
> (** Sorry, I'm resending this mail. I had written the subject in the
> Reply-To field. **)
>
> Hello, I'm attaching two patches for the top Makefile.
>
> The first patch modifies LOCALVERSION definition such taht it uses
> patsubst instead of subst to remove surrounding double quotes from
> CONFIG_LOCALVERSION. This helps syntax-highlighting editors.
>
> The second patch addes -fno-omit-frame-pointer to CFLAGS when
> CONFIG_FRAME_POINTER is set. My gcc (gcc-3.3.4 Debian 1:3.3.4-11)
> automatically turns on -fomit-frame-pointer when -O2 is specified and
> thus breaks CONFIG_FRAME_POINTER option. I'm not sure if other
> versions of gcc wouldn't choke with -fno-omit-frame-pointer. My 2.95
> (2.95.4) seems to be OK though.

Applied both.
Next time please send a single patch/mail.

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/