Re: [PATCH 2.6.9-rc3] Fix 'htmldocs' and friends with O=

[Sam Ravnborg]

On Tue, Oct 05, 2004 at 02:28:14AM +0200, Tonnerre wrote:
> Salut,
> 
> On Mon, Oct 04, 2004 at 04:39:58PM -0700, Tom Rini wrote:
> > --- linux-2.6.9-rc3.orig/scripts/kernel-doc
> > +++ linux-2.6.9-rc3/scripts/kernel-doc
> > @@ -1531,7 +1531,7 @@ sub process_state3_type($$) { 
> >  }
> >  
> >  sub process_file($) {
> > -    my ($file) = @_;
> > +    my ($file) = "$ENV{'SRCTREE'}@_";
> >      my $identifier;
> >      my $func;
> >      my $initial_section_counter = $section_counter;
> 
> From performance/memory footprint standpoint it might be better to use
> the dot operator here for concatenation.

For this usage I prefer readability for us who are not familiar with perl.
For me a '.' is used as thousand separator and end of line. No
usage for concatenation seems intuitive.
So I let it be as-is.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/