Re: [PATCH 1/4] mlockall(MCL_FUTURE) unlocks currently locked mappings

[Chris Wright]

* Andrew Morton (akpm@xxxxxxxx) wrote:
> Chris Wright <chrisw@xxxxxxxx> wrote:
> >
> > Calling mlockall(MCL_FUTURE) will erroneously unlock any currently locked
> > mappings.  Fix this up, and while we're at it, remove the essentially
> > unused error variable.
> 
> eek.
> 
> I've always assumed that mlockall(MCL_FUTURE) pins all your current pages
> as well as future ones.  But no, that's what MCL_CURRENT|MCL_FUTURE does.
> 
> So when we fix this bug, we'll break my buggy test apps.
> 
> I wonder what other apps we'll break?

I don't think it will break apps.  The only difference is that it won't
unlock already locked mappings.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/