Re: [patch] inotify: make user visible types portable

From: Robert Love
Date: Thu Sep 30 2004 - 17:40:55 EST


On Thu, 2004-09-30 at 18:25 -0400, Robert Love wrote:

> (speaking of which, we had 'mask' as an 'unsigned long' inside inotify.c,
> so this change was needed anyhow).

Ugh. We _also_ add mask sprinkled about as an int.

This patch makes those __u32 types, too.

Robert Love

s/int mask/__u32 mask/

Signed-Off-By: Robert Love <rml@xxxxxxxxxx>

drivers/char/inotify.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

--- linux-inotify/drivers/char/inotify.c 2004-09-30 18:25:19.102473088 -0400
+++ linux/drivers/char/inotify.c 2004-09-30 18:29:03.495360184 -0400
@@ -136,7 +136,7 @@
iput(inode);
}

-struct inotify_kernel_event *kernel_event(int wd, int mask,
+struct inotify_kernel_event *kernel_event(int wd, __u32 mask,
const char *filename)
{
struct inotify_kernel_event *kevent;
@@ -319,7 +319,7 @@
* Grabs dev->lock, so the caller must not hold it.
*/
static struct inotify_watcher *create_watcher(struct inotify_device *dev,
- int mask, struct inode *inode)
+ __u32 mask, struct inode *inode)
{
struct inotify_watcher *watcher;