Re: [PATCH 2.6] Natsemi - remove compilation warnings

[Jeff Garzik]

David S. Miller wrote:
> On Thu, 30 Sep 2004 14:21:57 -0400
> Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
>
>
> > Wouldn't it be better to just phase out the base of dev->base_addr 
> > completely?  I tend to prefer adding a "void __iomem *regs" to struct 
> > netdev_private, and ignore dev->base_addr completely.
>
>
> Yes, this is the way to go.
>
> (BTW, Jeff, technically it's the 'ifmap' that the user uses
>  to pass base_addr into the kernel.  The kernel drivers use
>  the netdev struct one, which is an unsigned long)

Yep, that's why it's truncated to 16-bits in ifconfig output.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/