Re: [PATCH] add sysfs attribute 'carrier' for net devices - try 2.

From: Nico Schottelius
Date: Tue Sep 28 2004 - 15:56:16 EST


Hello!

I am just a bit tired and a bit confused, but

Jesper Juhl [Tue, Sep 28, 2004 at 09:23:25PM +0200]:
> > > Using snprintf in this way is kind of silly. since buffer is PAGESIZE.
> > > The most concise format of this would be:
> > > return sprintf(buf, dec_fmt, !!netif_carrier_ok(dev));

wouldn't this potentially open a security hole / buffer overflow?

I am currently not really seeing where buf is passed from and what
dec_fmt is, but am I totally wrong?

Nico

--
Keep it simple & stupid, use what's available.
Please use pgp encryption: 8D0E 27A4 is my id.
http://nico.schotteli.us | http://linux.schottelius.org

Attachment: pgp00000.pgp
Description: PGP signature