Re: [PATCH] cyclades.c sysfs statistics support

[Marcelo Tosatti]

On Tue, Sep 28, 2004 at 07:12:43AM -0700, Greg KH wrote:
> On Tue, Sep 28, 2004 at 09:04:21AM -0300, Marcelo Tosatti wrote:
> > +    device_create_file(&(cy_card[info->card].pdev->dev), &_cydas[line]);            
> 
> Why the array of attributes?  As you only have one (which is wrong...)
> you only need one attribute structure.

Because each of them has a different name. I talked to him 
and he will probably stick the attribute inside each 
device structure.

> > +  show_sys_data - shows the data exported to sysfs/device, mostly the signals status involved in the
> > +  serial communication such as CTS,RTS,DTS,etc
> 
> NO!  sysfs is 1 value per file.  Not a whole bunch of values per one
> file.  Please change this to create a whole bunch of little files, not
> one big one.

Germano will do so.

We really appreciate your comments! Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/