Re: [BUG: 2.6.9-rc2-bk11] input completely dead in X

[Vojtech Pavlik]

On Tue, Sep 28, 2004 at 01:26:19AM -0500, Dmitry Torokhov wrote:
> Resending as I forgot to CC Vojtech and Peter first time around...
> 
> On Monday 27 September 2004 10:46 pm, Micha Feigin wrote:
> > > Or better yet, use the auto-dev feature, which should work if you have
> > > a new enough X driver and kernel patch.
> > > 
> > 
> > auto-dev doesn't work for me and I don't have time to check it
> > out.
> 
> Addition of Kensington ThinkingMouse / ExpertMouse support caused Synaptics
> and ALPS protocol numbers to move to 8 and 9 respectively which broke Peter's
> auto-dev detection. 

Ouch. I suspected something bad will happen.

> Vojtech, we need to keep protcol numbers stable, I propose something like this:
> 
> enum psmouse_type {
>         PSMOUSE_PS2             = 0,
>         PSMOUSE_PS2PP,
>         PSMOUSE_THINKPS,
>         PSMOUSE_GENPS           = 64,   /* 4 byte protocol start */
>         PSMOUSE_IMPS,
>         PSMOUSE_IMEX,
>         PSMOUSE_SYNAPTICS       = 128,  /* 5+ byte protocols start */
>         PSMOUSE_ALPS,
> };

No, we really need to keep backwards compatibility with the numbering
here and solve the packetsize issue elsewhere. Probably the best would
be for each of the protocols to have its own packet collection routine,
like the Synaptics and ALPS already have. It could be shared among the
simpler protocols.

We'll need this anyway for a heuristic resynchronizer.

> Peter, if we adopt the scheme above you will have to check both for old and
> new protocol numbers; in addition you need to BTN_TOOL_FINGER device bit to
> make sure you are dealing with a touchpad.
> 
> Any holes here?
 
I really would prefer if old installations of the X driver would work
with new kernel without the need to upgrade the X driver. I propose to
keep the protocol numbers intact, and if possible to also find a better
way for the X driver to detect a touchpad than relying on the IDs of the
input device, namely based on BTN_TOOL_FINGER presence.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/