Re: [PATCH] __VMALLOC_RESERVE export

[Christoph Hellwig]

> On Mon, Sep 27, 2004 at 06:12:29PM +0100, Christoph Hellwig wrote:
> > On Tue, Sep 28, 2004 at 03:03:43AM +1000, Antony Suter wrote:
> > > __VMALLOC_RESERVE itself is not exported but is used by something that
> > > is. This patch is against 2.6.9-rc2-bk11
> > > 
> > > This is required by the nvidia binary driver 1.0.6111
> > 
> > And the driver does absolutely nasty things it shouldn't do.  This is an
> > implementation detail that absolutely should not be exported.
> 
> NVidia isn't the only user...
> 
> Every  kernel  module  that  uses  just anything  that  uses  the  old
> __VMALLOC_RESERVE define was broken without this patch.

NVidia doesn't have a monopoly on crappy drivers, news at eleven..

__VMALLOC_RESERVE/VMALLOC_RESERVE is only used either in arch/i386 or
defined to MAXMEM whichs is also not used outside of arch/{i386,x86_64,mips}.

Doesn't exactly sounds like a published interface, heh?  Especially as there's
not sane way to use it outside memory managment code.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/