Re: [PATCH] __VMALLOC_RESERVE export

From: Christoph Hellwig
Date: Mon Sep 27 2004 - 13:46:30 EST


On Tue, Sep 28, 2004 at 04:26:43AM +1000, Antony Suter wrote:
> On Tue, 2004-09-28 at 03:12, Christoph Hellwig wrote:
> > On Tue, Sep 28, 2004 at 03:03:43AM +1000, Antony Suter wrote:
> > > __VMALLOC_RESERVE itself is not exported but is used by something that
> > > is. This patch is against 2.6.9-rc2-bk11
> > >
> > > This is required by the nvidia binary driver 1.0.6111
> >
> > And the driver does absolutely nasty things it shouldn't do. This is an
> > implementation detail that absolutely should not be exported.
>
> However __VMALLOC_RESERVE, specific to arch-i386 is now used by the
> macro MAXMEM. MAXMEM is _not_ specific to arch-i386. The nvidia driver
> has a kernel module that uses the macro MAXMEM. Is it wrong for a kernel
> module to use MAXMEM?

Yes.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/