Re: [patch 02/26] char/cyclades: replace schedule_timeout() with msleep_interruptible()

[Nishanth Aravamudan]

On Thu, Sep 23, 2004 at 10:24:58PM +0200, janitor@xxxxxxxxxxxxxx wrote:
> 
> 
> 
> Any comments would be appreciated. 
> 
> Description: Use msleep_interruptible() instead of schedule_timeout()
> to guarantee the task delays as expected.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxx>
> 
> Signed-off-by: Maximilian Attems <janitor@xxxxxxxxxxxxxx>
> ---
> 
>  linux-2.6.9-rc2-bk7-max/drivers/char/cyclades.c |    9 +++------
>  1 files changed, 3 insertions(+), 6 deletions(-)
> 
> diff -puN drivers/char/cyclades.c~msleep_interruptible-drivers_char_cyclades drivers/char/cyclades.c
> --- linux-2.6.9-rc2-bk7/drivers/char/cyclades.c~msleep_interruptible-drivers_char_cyclades	2004-09-21 21:07:58.000000000 +0200
> +++ linux-2.6.9-rc2-bk7-max/drivers/char/cyclades.c	2004-09-21 21:07:58.000000000 +0200
> @@ -2717,8 +2717,7 @@ cy_wait_until_sent(struct tty_struct *tt
>  #ifdef CY_DEBUG_WAIT_UNTIL_SENT
>  	    printk("Not clean (jiff=%lu)...", jiffies);
>  #endif
> -	    current->state = TASK_INTERRUPTIBLE;
> -	    schedule_timeout(char_time);
> +	    msleep_interruptible(msecs_to_jiffies(char_time));

Looks like the wrong macro was used here (should be jiffies_to_msecs()).
Max, want me to send it to you again?

-Nish
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/