RE: suspend/resume support for driver requires an external firmware

From: Zhu, Yi
Date: Fri Sep 24 2004 - 10:11:20 EST


Patrick Mochel wrote:
> We talked about this in Ottawa a few months ago, and I think
> this is the right approach. Note though, that I think it
> needs to be more complete:
>
> - There needs to be restore_state() to be symmetic.
> - There needs to be the proper failure recovery
> If save_state() or suspend() fails, every device that has had their
> state saved needs to be restored.
> - It needs to be called for all power management requests.

Agreed.

> - The PCI implementation should call pci_save_state() in it,
> instead of in ->suspend().

Also agree. And split pci_restore_state() from ->resume to
->restore_state. But all current drivers need to be rewritten.

Thanks,
-yi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/