[patch 16/26] char/pcxx: replace schedule_timeout() with msleep_interruptible()

From: janitor
Date: Thu Sep 23 2004 - 15:42:17 EST





Any comments would be appreciated.

Description: Use msleep_interruptible() instead of schedule_timeout() to
guarantee the task delays as expected.

Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxx>
Looks fine to me.
Signed-off-by: Christoph Lameter <christoph@xxxxxxxxxxx>

Signed-off-by: Maximilian Attems <janitor@xxxxxxxxxxxxxx>
---

linux-2.6.9-rc2-bk7-max/drivers/char/pcxx.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)

diff -puN drivers/char/pcxx.c~msleep_interruptible-drivers_char_pcxx drivers/char/pcxx.c
--- linux-2.6.9-rc2-bk7/drivers/char/pcxx.c~msleep_interruptible-drivers_char_pcxx 2004-09-21 21:08:15.000000000 +0200
+++ linux-2.6.9-rc2-bk7-max/drivers/char/pcxx.c 2004-09-21 21:08:15.000000000 +0200
@@ -555,8 +555,7 @@ static void pcxe_close(struct tty_struct
#endif
if(info->blocked_open) {
if(info->close_delay) {
- current->state = TASK_INTERRUPTIBLE;
- schedule_timeout(info->close_delay);
+ msleep_interruptible(jiffies_to_msecs(info->close_delay));
}
wake_up_interruptible(&info->open_wait);
}
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/