Re: [PATCH 1/3] MMC compatibility fix - GO_IDLE

[Pierre Ossman]

Russell King wrote:

> On Sat, Sep 18, 2004 at 11:56:42AM +0200, Pierre Ossman wrote:
>  
>
> > This patch adds a GO_IDLE before sending a new SEND_OP_COND (as required 
> > by MMC standard).
> >    
>
> Thanks; I haven't completely vanished off the face of the planet.
>  
Good to know. You've seemed a bit busy :)

> We already have a function using MMC_GO_IDLE_STATE, so I suggest we
> separate this out.  If you need a 1ms delay after sending this, maybe
> the other case also needs this delay as well?
>
>  
The delay was added just in case. The cards I have here work fine 
without it. I just thought adding a small delay might avoid problematic 
cards later on. Seems to be a few of those.

> How about this patch?
>
>  
Looks ok. You sure we don't need to put all cards into an idle state 
before issuing a new SEND_OP_COND? I haven't studied how the MMC layer 
is called in detail. Can a rescan be done while a card is in a selected 
state?

Rgds
Pierre

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/