Re: [RFC, 2.6] a simple FIFO implementation

From: Kyle Moffett
Date: Fri Sep 17 2004 - 22:43:33 EST


On Sep 17, 2004, at 18:29, Ryan Cumming wrote:
Er, sorry, the last patch was had an off-by-one error (it would round 4 up to
8).

+static inline unsigned long __attribute_pure__ roundup_pow_of_two(int x)

This should probably be __const__, which is a stricter class of __pure__.
The "__pure__" attribute means it has no side effects, whereas the
"__const__" attribute means that it also _only_ depends on its arguments,
not on any global memory or the data at any pointers passed to it.

Cheers,
Kyle Moffett

-----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GCM/CS/IT/U d- s++: a17 C++++>$ UB/L/X/*++++(+)>$ P+++(++++)>$
L++++(+++) E W++(+) N+++(++) o? K? w--- O? M++ V? PS+() PE+(-) Y+
PGP+++ t+(+++) 5 X R? tv-(--) b++++(++) DI+ D+ G e->++++$ h!*()>++$ r !y?(-)
------END GEEK CODE BLOCK------


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/