Re: [2.6.9-rc2-bk] Network-related panic on boot

[David S. Miller]

Already fixed.  Patch below:

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/09/17 11:11:23-07:00 david@xxxxxxxxxxxxxxxxxxxxx 
#   [IPV4]: Initialize newly allocated hash tables in fib_semantics.c
#   
#   When fib_create_info() allocates new hash tables, it neglects to
#   initialize them.  This leads to an oops during boot on at least
#   machine I use.  This patch addresses the problem.
#   
#   Signed-off-by: David Gibson <dwg@xxxxxxxxxxx>
#   Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
# 
# net/ipv4/fib_semantics.c
#   2004/09/17 11:11:04-07:00 david@xxxxxxxxxxxxxxxxxxxxx +5 -1
#   [IPV4]: Initialize newly allocated hash tables in fib_semantics.c
#   
#   When fib_create_info() allocates new hash tables, it neglects to
#   initialize them.  This leads to an oops during boot on at least
#   machine I use.  This patch addresses the problem.
#   
#   Signed-off-by: David Gibson <dwg@xxxxxxxxxxx>
#   Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
# 
diff -Nru a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
--- a/net/ipv4/fib_semantics.c	2004-09-17 15:33:41 -07:00
+++ b/net/ipv4/fib_semantics.c	2004-09-17 15:33:41 -07:00
@@ -604,8 +604,12 @@
 		if (!new_info_hash || !new_laddrhash) {
 			fib_hash_free(new_info_hash, bytes);
 			fib_hash_free(new_laddrhash, bytes);
-		} else
+		} else {
+			memset(new_info_hash, 0, bytes);
+			memset(new_laddrhash, 0, bytes);
+
 			fib_hash_move(new_info_hash, new_laddrhash, new_size);
+		}
 
 		if (!fib_hash_size)
 			goto failure;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/