Re: [RFC, 2.6] a simple FIFO implementation

[Buddy Lucas]

On Thu, 16 Sep 2004 17:29:19 +0200, Stelian Pop <stelian@xxxxxxxxxx> wrote:
> On Thu, Sep 16, 2004 at 05:09:51PM +0200, Buddy Lucas wrote:
> 
> > > +       total = remaining = min(len, fifo->size - fifo->tail + fifo->head);
> >
> > I could be mistaken (long day at the office ;-) but doesn't this fail after
> > wrapping?
> 
> No, because the type is *unsigned* int.

Indeed, that would exactly be the reason *why* this would fail. ;-) 

The expression fifo->size - fifo->tail + fifo->head might be negative
at some point, right? (fifo->head has wrapped to some small value and
fifo->tail > fifo->size)


Cheers,
Buddy

> 
> Stelian.
> --
> 
> 
> Stelian Pop <stelian@xxxxxxxxxx>
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/