Re: [PATCH] remove LOCK_SECTION from x86_64 spin_lock asm

From: Andi Kleen
Date: Thu Sep 16 2004 - 04:07:22 EST


On Thu, Sep 16, 2004 at 09:44:31AM +0200, Ingo Molnar wrote:
>
> * Andi Kleen <ak@xxxxxxx> wrote:
>
> > Something is mixed up here:
> >
> > The whole problem only happens on kernels using frame pointer. I never
> > saw it, simply because I don't use frame pointers.
> >
> > On a frame pointer less kernel profiling works just fine, and with
> > this fix it should work the same on a FP kernel.
>
> it only works on pointer less kernels because the spinlock profile
> unwinding is _conditional_ on an FP kernel right now:

Actually my idea doesn't work because there is a one instruction
race where rbp is not set up on the stack yet. I think I give up and just save
%rbp in this case.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/