Re: [PATCH] hvc_console fix to protect hvc_write against ldiscwrite after hvc_close

[Ryan Arnold]

On Wed, 2004-09-15 at 15:41, Theodore Ts'o wrote:
> The current (I can't speak to what Alan Cox is going to change) rules
> with tty drivers is that tty drivers are supposed to close the line
> discpline in their close routines.  That's the much safer and cleaner
> way of fixing this problem, and it is in line with what most of the
> other tty drivers are doing.
				- Ted

Thanks for the pointer Ted.  I've looked through the drivers/char
directory but I must be blind because all I see other drivers doing is
setting tty->closing = 1 (and then = 0 later) and
ldsic->flush_buffer().  Is flush_buffer() what you're refering to?  The
tty->closing variable just seems to prevent the ldisc from reading.

Ryan S. Arnold
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/