Re: notify_parent (was: Re: Linux 2.6.9-rc2)

[Roland McGrath]

> On Mon, 13 Sep 2004, Linus Torvalds wrote:
> > Roland McGrath:
> >   o cleanup ptrace stops and remove notify_parent
> 
> However, there are still a few users of notify_parent():

IIRC all these are old arch-specific signal code that is rampantly wrong in
semantics compared to what the up-to-date arch's using the generic code do,
for quite a long time now.  I believe I mentioned this when I posted the
patch.  All this arch signal code needs to be rewritten to use
get_signal_to_deliver, and define ptrace_signal_deliver appropriately to
get its arch-specific work done.  The old style of code that does all the
central signal dispatch logic itself is hopeless.  Mostly you have a lot of
old cruft to remove, and the code that needs to be left is much smaller and
simpler because the complex stuff is in the shared kernel/signal.c.

> You forgot to add `struct rusage _rusage' members to struct siginfo._sigchld
> for 2 architectures that define HAVE_ARCH_SIGINFO_T.

I didn't forget.  I never claimed to update other arch's.  The arch
maintainers need to keep up with patches like you are doing with these
here.  Most other arch maintainers have submitted their updates already.
You may need to update some copy_*_siginfo functions if your arch's
have them in compat code as well.



Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/