Re: [PATCH] New QStor SATA/RAID Driver for 2.6.9-rc2

[Mark Lord]

Alan Cox wrote:
> Correct ioctl return is -ENOTTY for unknown (thats a mistake still in
> many existing drivers so no suprise its still being copied)

Quoting linux/Documentation/scsi_mid_low_api.txt:
*
*      Unfortunately some applications expect -EINVAL and react badly
*      when -ENOTTY is returned; stick with -EINVAL.

Looks like a documentation fix is needed then.

This is a hardware RAID device, with various graduations of sharing
possible between hardware and software.   It was originally written
pre-libata, and the RAID functionality in particular does not map
well to libata.  Nor do the host-queuing implementation and other features.

Thanks Alan.  I'll address the other points you brought up later.

Cheers
--
Mark Lord
(hdparm keeper & the original "Linux IDE Guy")
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/