Re: Changes to ide-probe.c in 2.6.9-rc2 causing improper detection

From: Bartlomiej Zolnierkiewicz
Date: Tue Sep 14 2004 - 08:08:24 EST


On Tuesday 14 September 2004 12:05, Alan Cox wrote:
> On Maw, 2004-09-14 at 07:06, Jens Axboe wrote:
> > Alan, I bet there are a lot of these. Maybe we should consider letting
> > the user manually flag support for FLUSH_CACHE, at least it is in their
> > hands then.
>
> You are assuming the drive supports "FLUSH_CACHE" just because it
> doesn't error it. Thats a good way to have accidents.

Yep.

> The patch I posted originally did turn wcache off for barrier if no
> flush cache support was present but had a small bug so that bit got
> dropped.

'small bug' was that it didn't disable wcache except one
error case (which I've never seen in the wild). 8)

Check what ioctl hdparm uses for enabling wcache
and then think about implications for disabling wcache
by default.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/