Re: 2.6.9-rc1-mm5 bug in tcp_recvmsg?

[Jesse Barnes]

On Monday, September 13, 2004 4:55 pm, David S. Miller wrote:
> On Mon, 13 Sep 2004 16:54:27 -0700
>
> Jesse Barnes <jbarnes@xxxxxxxxxxxx> wrote:
> > tg3.  I saw one trace that included do_poll (iirc) and another last week
> > that had sys_select in it.  I'll try to gather some more info.
>
> What you're seeing might be due to the bug fixed by this patch:

>       spin_lock(&dev->queue_lock);
>       return -1;
>      }
> -    if (ret == NETDEV_TX_LOCKED && nolock)
> +    if (ret == NETDEV_TX_LOCKED && nolock) {
> +     spin_lock(&dev->queue_lock);
>       goto collision;
> +    }
>     }
>
>     /* NETDEV_TX_BUSY - we need to requeue */

Ok, I guess that would explain why I haven't seen this in 2.6.9-rc2.  I was 
getting my backtraces confused too--I've only seen this one for this bug.  
I'll keep an eye out and report anything I see with the latest bk tree.

Thanks,
Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/