RE: 2.4.28-pre3: broken ips update

[Hammer, Jack]

I concur with Arjan's critique.  

Please disregard this patch and I will create a new one, with Arjan's
recommendation, shortly.

Jack 



-----Original Message-----
From: Arjan van de Ven [mailto:arjanv@xxxxxxxxxx] 
Sent: Monday, September 13, 2004 10:46 AM
To: Hammer, Jack
Cc: Adrian Bunk; Marcelo Tosatti; linux-kernel@xxxxxxxxxxxxxxx;
linux-scsi@xxxxxxxxxxxxxxx
Subject: RE: 2.4.28-pre3: broken ips update

On Mon, 2004-09-13 at 16:28, Hammer, Jack wrote:
> Marcelo,

> --- linux.orig/drivers/scsi/ips.h	Mon Sep 13 09:40:04 2004
> +++ linux/drivers/scsi/ips.h	Mon Sep 13 09:40:27 2004
> @@ -97,7 +97,7 @@
>  
>     #if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)
>     
> -      #ifndef irqreturn_t
> +      #if LINUX_VERSION_CODE < KERNEL_VERSION(2,4,23)
>           typedef void irqreturn_t;
>        #endif
> 

your fix is wrong.
you should nuke all version codes, and ONLY ifndef for  IRQ_NONE and
nothing else. That's not just cosmetics, that's also to make keep
working with those exact vendor kernels  you claim to have tested on :)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/