Re: 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_sub_and_test

From: Roman Zippel
Date: Mon Sep 13 2004 - 09:13:29 EST


Hi,

On Mon, 13 Sep 2004, Hugh Dickins wrote:

> On Mon, 13 Sep 2004, Roman Zippel wrote:
> > On Mon, 13 Sep 2004, Hugh Dickins wrote:
> >
> > > But Bill already said he doesn't want it, [...]
> > >
> > > - if (atomic_sub_and_test(bio->bi_vcnt, &fq->nr_submitted))
> > > + if (atomic_sub_return(bio->bi_vcnt, &fq->nr_submitted) == 0)
> >
> > And that is more portable how?
>
> It's more portable in that all but s390 already provide it
> (and I expect Martin will be happy to add it).

So why not add the missing atomic_sub_and_test() (using simply
atomic_sub_return)?

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/