Re: [PATCH]: Re: kernel 2.6.9-rc1-mm4 oops

[Roel van der Made]

Hi,

On Mon, Sep 13, 2004 at 11:24:43AM +0200, Ingo Molnar wrote:
> * Kirill Korotaev <dev@xxxxx> wrote:
> > >the BUG() is useful for all the code that uses next_thread() - you can
> > >only do a safe next_thread() iteration if you've locked ->sighand.
> > 1. I don't see spin_lock() on p->sighand->siglock in do_task_stat() 
> > before calling next_thread(). And the check inside next_thread() permits 
> > only one of the locks to be taken:
> >         if (!spin_is_locked(&p->sighand->siglock) &&
> >                                 !rwlock_is_locked(&tasklist_lock))

<snip>

> > the last check ensures that we are still hashed and this check is more 
> > straithforward for understanding, agree?
> 
> yep - please send a new patch to Andrew.

I'll be awaiting the patch and give it a shot.

Thanks all for the feedback.

-- 
Roel van der Made                             .--.
GNU/Linux Systems/Network Engineer           |o_o |
Telegraaf Media ICT - Internet Services      |:_/ |
Tel.: 020 585 2229                          //   \ \
GnuPG Key available at: http://roel.net/gpgkey.asc

Attachment: pgp00000.pgp
Description: PGP signature