Re: [PATCH] sata_svw: Fix __iomem related warnings

[Christoph Hellwig]

On Mon, Sep 13, 2004 at 02:27:22PM +1000, Benjamin Herrenschmidt wrote:
> This patch adds some (ugly) casts to sata_svw to remove the
> warnings generated by the new iomem stuff.

Umm, maybe it's just me - but shouldn't you fix them properly?

> 
> -		writeb(tf->ctl, ioaddr->ctl_addr);
> +		writeb(tf->ctl, (void __iomem *)ioaddr->ctl_addr);

e.g. ioaddr->ctl_addr should get a __iomem attribute

> +		writew(tf->feature | (((u16)tf->hob_feature) << 8),
> +		       (void __iomem *)ioaddr->feature_addr);
> +		writew(tf->nsect | (((u16)tf->hob_nsect) << 8),
> +		       (void __iomem *)ioaddr->nsect_addr);
> +		writew(tf->lbal | (((u16)tf->hob_lbal) << 8),
> +		       (void __iomem *)ioaddr->lbal_addr);
> +		writew(tf->lbam | (((u16)tf->hob_lbam) << 8),
> +		       (void __iomem *)ioaddr->lbam_addr);
> +		writew(tf->lbah | (((u16)tf->hob_lbah) << 8),
> +		       (void __iomem *)ioaddr->lbah_addr);

dito for all the others.

just hacking around the annotations with casts seems ather pointless.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/