Re: [PATCH] Interrupt entry CONFIG_FRAME_POINTER fix

[Andi Kleen]

On Sun, 12 Sep 2004 18:16:28 +0900
Tejun Heo <tj@xxxxxxxxxxx> wrote:

>  On x86_64, rbp isn't saved on entering interrupt handler even when
> CONFIG_FRAME_POINTER is turned on.  This breaks profile_pc()
> (resulting in oops) which uses regs->rbp to track back to the original
> stack.  Save full stack when CONFIG_FRAME_POINTER is specified.


I don't think your patch is correct, you don't restore rbp ever and it gets corrupted.

I think the correct change is to fix profile_pc() to not reference rbp, but just hardcode
the rsp offset for the FP and non FP cases (8 and 0) 

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/