Re: 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_sub_and_test

From: William Lee Irwin III
Date: Sun Sep 12 2004 - 05:57:33 EST


On Sun, Sep 12, 2004 at 03:12:35AM -0700, Paul Jackson wrote:
> The final link fails with:
> fs/built-in.o(.text+0x58618): In function `end_io_handler':
> : undefined reference to `atomic_sub_and_test'
> make[1]: *** [arch/sparc/boot/image] Error 1
> The macro 'atomic_sub_and_test' is defined for more or less every other
> arch, in various include/asm-*/atomic.h files, but not defined for
> sparc.
> This macro is used in:
> fs/reiser4/flush_queue.c:
> if (atomic_sub_and_test(bio->bi_vcnt, &fq->nr_submitted))
> If I disable the config items:
> CONFIG_REISER4_FS=y
> CONFIG_REISER4_LARGE_KEY=y
> then it builds ok (with the bogus #else removed from cachefs.h, as
> already reported on lkml).

I'm loath to add this for the sake of reiser4; I rather favor the use of
portable constructs.


-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/