Re: [PATCH] i386 reduce spurious interrupt noise

From: Maciej W. Rozycki
Date: Fri Sep 10 2004 - 19:15:27 EST


On Fri, 10 Sep 2004, Chris Wedgwood wrote:

> > > - printk (KERN_INFO "APIC error on CPU%d: %02lx(%02lx)\n",
> > > + printk (KERN_DEBUG "APIC error on CPU%d: %02lx(%02lx)\n",
>
> > This should probably be KERN_ERR even. This is a serious condition -- if
> > you ever get such a message, then inter-APIC messages get corrupted and
> > this affects system's stability.
>
> These messages are very common on many platforms, infrequent (once
> very few days to twice a day at most in my observations) and seemingly
> harmless.

These are just as harmless as single-bit RAM errors with ECC working.
In both cases you want the problem to be reported.

> I agree that if you get *many* of these certainly that would indicate
> there is a problem but I've not not heard a single instance of this
> and if that is the case we need to deal with it differently.

Please search list archives for lots of such reports.

> > > - printk("spurious 8259A interrupt: IRQ%d.\n", irq);
> > > + printk(KERN_DEBUG "spurious 8259A interrupt: IRQ%d.\n", irq);
>
> > You may ever get a single message per system boot from this line.
>
> Sometimes as boot, though often in my experience several minutes after
> boot.

And never again until you reboot. That's what I mean.

> > It encourages to have a look at the ERR counter in /proc/interrupts
> > to check for possible problems, though admittedly the suggestion
> > isn't especially clear.
>
> I think in *both* cases we want to detect a largish (more than 1 ever
> n seconds or so) number of these and then complain, not before and
> even then not excessively so that we printk our-selves to death.

I agree for the latter case. I won't mind the message going away either.
For the former you only really want to rate-limit the report -- some
people apparently want or need to run broken hardware and they'd probably
appreciate limiting the output.

Maciej
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/