Re: [PATCH] sis5513 fix for SiS962 chipset

[Lionel Bouton]

Thomas Gleixner wrote the following on 09/10/2004 04:29 PM :

> Hi,
>
> 1. If the fake 5513 id bit is not set by the BIOS we must have the 5518
> id in the device table.
>
> 2. If the register remapping is not set by the BIOS then the enable bit
> check in ide_pci_setup_ports will fail. It's safe to switch to the
> remapping mode here. Keeping the not remapped mode would need quite big
> changes AFAICS.
>  

I was worried about these when 5518 was introduced but couldn't test on 
the hardware I had at hand and nobody reported hitting this so it went 
under the carpet. What hardware did you use to test ?

--
Lionel Bouton - inet6
---------------------------------------------------------------------
  o              Siege social: 51, rue de Verdun - 92158 Suresnes
 /      _ __ _   Acces Bureaux: 33 rue Benoit Malon - 92150 Suresnes
/ /\  /_  / /_   France
\/  \/_  / /_/   Tel. +33 (0) 1 41 44 85 36
 Inetsys S.A.    Fax  +33 (0) 1 46 97 20 10


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/