Re: [PATCH 4/4] copyfile: copyfile

[Herbert Poetzl]

On Tue, Sep 07, 2004 at 05:21:18PM +0200, Jörn Engel wrote:
> On Tue, 7 September 2004 07:59:11 -0700, Linus Torvalds wrote:
> > On Tue, 7 Sep 2004, Jörn Engel wrote:
> > > 
> > > Does that mean that you're ok with the first three patches?
> > 
> > No, it means that they weren't fundamentally flawed..
> 
> It's a start...
> 
> > Actually, the 4kB batching one was - if you only max out to using 4kB at a 
> > time, sendfile() is kind of pointless, because then it will never do 
> > multi-page copies in the first place, and all the complexity at a lower 
> > level is worthless..
> 
> Give me a better number.  16k?  1M?  Or would it not be fundamentally
> flawed if the unit was seconds, instead of bytes?  That makes a lot
> more sense, since a floppy and a Ultra320 RAID array differ slightly
> in speed and it's response time the users actually care about.

maybe the 'block/buffer' size could be passed with the
syscall (maybe with a kernel default), allowing dumb tools 
to use a fixed value and smart ones, exactly what the user 
desires ...

best,
Herbert

> Jörn
> 
> -- 
> /* Keep these two variables together */
> int bar;
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/